dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
This LGTM, with one more nit to consider.
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:163
+static constexpr bool is_int_convertible() {
+ return sizeof(T) <= sizeof(std::uint64_t) &&
+ std::is_trivially_constructible<T, std::uint64_t>::value &&
----------------
I don't remember seeing `std::uint*_t` elsewhere in LLVM code; I think we tend
to just say `uint64_t` (getting it from the C namespace). Unless you have a
specific reason for adding it I suggest dropping the qualifier.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83694/new/
https://reviews.llvm.org/D83694
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
