dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land.
LGTM with one nit. ================ Comment at: clang/include/clang/Driver/Options.td:1514 + MarshallingInfoFlag<"HeaderSearchOpts->ModulesValidateDiagnosticOptions", "true">, IsNegative; +// todo: simplify these into a version of OptInFFlag that accepts different flags for each record and does not imply group def fmodules_validate_system_headers : Flag<["-"], "fmodules-validate-system-headers">, ---------------- I think you can find cases like this later by looking for `def.*no_`, without the TODO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83940/new/ https://reviews.llvm.org/D83940 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
