rnk added inline comments.
================ Comment at: llvm/include/llvm/Config/llvm-config.h.cmake:95 +/* Define to 1 to enable the experimental new pass manager by default */ +#cmakedefine01 ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER + ---------------- aeubanks wrote: > rnk wrote: > > This should be namespaced in LLVM_*. > > > > Can we drop "experimental" now to shorten it? LLVM_ENABLE_NEW_PASS_MANAGER? > That would mean changing the CMake variable name which would break everybody > using the flag. I can add a #define alias if you want. You can leave the cmake option as it is, and make a new variable with the right name before the call to configure_file: set(LLVM_ENABLE_NEW_PASS_MANAGER ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92072/new/ https://reviews.llvm.org/D92072 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
