jdoerfert added inline comments.

================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:3203-3206
+  if (!SkippedClauses && Assumptions.empty())
+    Diag(Loc, diag::err_omp_no_clause_for_directive)
+        << llvm::omp::getAllAssumeClauseOptions()
+        << llvm::omp::getOpenMPDirectiveName(DKind);
----------------
ABataev wrote:
> Early exit from the function in case of error?
We can't always because we want to create an (empty) scope so we can diagnose 
the `end assumes` properly. I'll check in the non-scope case though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91980/new/

https://reviews.llvm.org/D91980

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to