MyDeveloperDay requested changes to this revision.
MyDeveloperDay added a comment.
This revision now requires changes to proceed.
Its close
================
Comment at: clang/lib/Format/Format.cpp:751
/*AfterFunction=*/false,
/*AfterNamespace=*/false,
/*AfterObjCDeclaration=*/false,
----------------
I think you may need to rebase, this code looks to be from before a relatively
recent change
================
Comment at: clang/lib/Format/Format.cpp:893
/*BeforeLambdaBody=*/false,
+ /*BeforeStructInitialization=*/false,
/*BeforeWhile=*/false,
----------------
I believe there are 3 places where BraceWrapping is initialized you seem to
only be doing 2 of them
================
Comment at: clang/unittests/Format/FormatTest.cpp:5063
+ " a = 1,\n"
+ " b = 2,\n"
+ "};",
----------------
could you add an additional test without the trailing `,`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91949/new/
https://reviews.llvm.org/D91949
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
