tmsriram added a comment. LGTM. I checked it completely and the patch makes total sense to me.
================ Comment at: clang/include/clang/Driver/Options.td:1866 def fno_pie : Flag<["-"], "fno-pie">, Group<f_Group>; +def fdirect_access_external_data : Flag<["-"], "fdirect-access-external-data">, Group<f_Group>, Flags<[CC1Option]>, + HelpText<"Don't use GOT indirection to reference external data symbols">; ---------------- Would -fdirect-access-external-global be a more appropriate name?, data sounds generic to me but I don't have a strong opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92633/new/ https://reviews.llvm.org/D92633 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
