nickdesaulniers added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/linuxkernel/ExtraSemiCheck.h:37
+  std::vector<const MacroInfo *> SuspectMacros;
+  enum ExtraSemiFixerKind FixerKind;
+  const std::string ExtraSemiFixerKindName;
----------------
aaron.ballman wrote:
> You can drop the `enum` elaboration here.
right, this is a difference between C and C++; for C the `enum` keyword would 
be required always; for C++ it's not, and generally is omitted.  (In C++ was 
also don't generally use `struct` or `class` for function parameters, or local 
variables, though you could.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91789/new/

https://reviews.llvm.org/D91789

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to