thakis added a comment. In D90871#2433804 <https://reviews.llvm.org/D90871#2433804>, @erik.pilkington wrote:
> In D90871#2433766 <https://reviews.llvm.org/D90871#2433766>, @thakis wrote: > >> Looks like this breaks tests on Windows: >> http://45.33.8.238/win/29181/step_7.txt >> >> PTAL, and revert while you investigate if it takes a while to fix. > > Thanks for letting me know, should be fixed by: > 4fa0dbd6885bc4a48ceecdbb0fca9638792762cf > <https://reviews.llvm.org/rG4fa0dbd6885bc4a48ceecdbb0fca9638792762cf> Thanks for the fix! But just adding a triple means the existing test in that file is no longer tested with the win api, which is not ideal. (But probably also not a huge deal.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
