jroelofs added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:108 + + return std::string(SysRootDir.str()); +} ---------------- abidh wrote: > jroelofs wrote: > > Small string has an implicit conversion to std::string, so you can just > > `return SysRootDir;` here. > I was getting a compile error on that. Looking in SmallString.h, it seems > that conversion to std::string is explicit. ohh, I see what's going on. doxygen doesn't list the explicit keyword in the html page, so I thought it was implicit. sorry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92677/new/ https://reviews.llvm.org/D92677 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
