miyuki added inline comments.
================ Comment at: llvm/unittests/Support/TargetParserTest.cpp:47 + if (!pass) + std::cout << "ExpectedFlags = 0x" << std::hex << ExpectedFlags + << " do not equal ExtKind = 0x" << std::hex << ExtKind ---------------- I suggest using LLVM I/O facilities instead of std::cout and stderr instead of stdout. E.g. ``` #include "llvm/Support/raw_ostream.h" #include "llvm/Support/Format.h" //... errs() << "ExpectedFlags = " << format_hex(ExpectedFlags, 8) << //... ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits