jansvoboda11 added a comment.

Left one question.



================
Comment at: clang/lib/Basic/SourceManager.cpp:567
+  if (IR.ContentsEntry->isNamedPipe())
+    (void)IR.getBufferOrNone(Diag, getFileManager(), SourceLocation());
+
----------------
What's the reason behind duplicating the logic here instead of calling 
`createFileID` with `const FileEntry *SourceFile`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92531/new/

https://reviews.llvm.org/D92531

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D92531: Re... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D9253... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D9253... Jan Svoboda via Phabricator via cfe-commits

Reply via email to