jdoerfert reopened this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
Apologies for being silent for too long.
This is missing a lang ref entry for `nocallback` and the `attributes.ll` test
is arguably broken (see below).
The "definition" in `llvm/include/llvm/IR/Attributes.td` (see below), does not
match the the behavior of `clang/test/CodeGen/attr-leaf.c`.
As I mentioned before, this doesn't have a meaning on definitions and that
needs to be captured in the semantics (and preferably the FE).
/// Function cannot enter into caller's translation unit.
================
Comment at: llvm/test/Bitcode/attributes.ll:408
+; CHECK; define void @f69() #43
+define void @f70() nocallback
+{
----------------
I kinda doubt this is going to work like it is supposed to.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90275/new/
https://reviews.llvm.org/D90275
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
