MaskRay accepted this revision. MaskRay added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Arch/M68k.h:38 +} // end namespace m68k +} // namespace tools +} // end namespace driver ---------------- mismatching `end` and no `end`? clang-format seems to drop `end`. I think that style can be picked if convenient. ================ Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2101 + static const char *const M68kLibDirs[] = {"/lib"}; + static const char *const M68kTriples[] = { ---------------- The second `const ` is redundant CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits