aaron.ballman added a comment. In D72241#2449426 <https://reviews.llvm.org/D72241#2449426>, @ffrankies wrote:
> @aaron.ballman Thank you! If there are no further comments, could you please > commit this on my behalf? My GitHub username is ffrankies > <https://github.com/ffrankies>. I'd be happy to except the diff seems to be causing me problems that I'm struggling to figure out how to solve. F:\llvm-project>git apply "F:\Aaron Ballman\Desktop\D72241.diff" F:/Aaron Ballman/Desktop/D72241.diff:207: trailing whitespace. Based on the `Altera SDK for OpenCL: Best Practices Guide F:/Aaron Ballman/Desktop/D72241.diff:213: trailing whitespace. F:/Aaron Ballman/Desktop/D72241.diff:230: trailing whitespace. F:/Aaron Ballman/Desktop/D72241.diff:279: trailing whitespace. // CHECK-MESSAGES-OLDCLOLDAOC: :[[@LINE-1]]:3: note: barrier call is in a sing le work-item and may error out F:/Aaron Ballman/Desktop/D72241.diff:339: trailing whitespace. // CHECK-MESSAGES-NEWCLOLDAOC: :[[@LINE-1]]:3: note: barrier call is in a sing le work-item and may error out error: clang-tidy/altera/AlteraTidyModule.cpp: No such file or directory error: clang-tidy/altera/CMakeLists.txt: No such file or directory error: docs/ReleaseNotes.rst: No such file or directory error: docs/clang-tidy/checks/list.rst: No such file or directory What's so strange is -- those files all exist for me. I tried switching the directory separators to be Windows separators, but then I got errors about invalid file paths. Can you rebase your patch on ToT and maybe that'll apply more cleanly for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72241/new/ https://reviews.llvm.org/D72241 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits