SouraVX added a comment. Thanks! for the patch, some minor comments inlined. Rest LGTM. Let others also have a look.
================ Comment at: clang/include/clang/Driver/Options.td:4329 HelpText<"Generate machine code, but discard output">; -def emit_obj : Flag<["-"], "emit-obj">, - HelpText<"Emit native object files">; ---------------- Please correct if I've misunderstood this change ? You're removing this option from here(`clang`) and defining again at line 4631 as a common option to both `clang` `flang` ? +1 to that. However this seems out of the purview of this patch. Do you think having this as a separate patch(with specific intent) would be good(For tracking/isolating changes) ? Or the least you can do is convey this intent in this patch Summary too. I'm happy with either of those :) ================ Comment at: flang/test/Flang-Driver/code-gen.f90:15 + +! CHECK: code-generation is not available yet ---------------- Since it's an `error` NOT a string(or similar) generated, I would rather have `ERROR` as a string check. This way it is self-evident for end reader. Sort of: ```! ERROR: code-generation is not available yet``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits