qchateau added a comment.
> Side note is this memory failing to free behaviour observed on windows?
No idea, I only develop on linux. Looking at the the github issues, it seems
people that had the issue were also using the linux version...so we can't
conclude anything about windows
================
Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:51
+void trimMemory() {
+ if (malloc_trim(0))
+ vlog("Trimmed memory");
----------------
njames93 wrote:
> It may be helpful to log how many times this call fails to free any memory.
From what I observed, it (almost?) never fails to free memory, although
sometimes it's only a few kB.
Anyway, are you suggesting to keep track of how many time we call `malloc_trim`
and how many times it fails ? Or simply logging when it fails ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93452/new/
https://reviews.llvm.org/D93452
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
