alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

Looks good with one nit.

Thank you for implementing this!


================
Comment at: clang-tidy/tool/ClangTidyMain.cpp:320
@@ +319,3 @@
+  if (ExplainConfig) {
+    std::vector<clang::tidy::ClangTidyOptionsProvider::OptionsSource>
+        RawOptions = OptionsProvider->getRawOptions(FileName);
----------------
Sorry for being not clear. We still need to find a way to display the source of 
other components of the configuration. So the FIXME was fine, just the wording 
was confusing. Please add the FIXME back, but just remove the "more elegant" 
part.


http://reviews.llvm.org/D18694



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to