curdeius added inline comments.
================ Comment at: clang/docs/ClangFormatStyleOptions.rst:2463 +**MaxUnwrappedLinesForShortNamespace** (``unsigned``) + The maximal number of unwrapped lines that a short namespace spans. ---------------- HazardyKnusperkeks wrote: > curdeius wrote: > > MyDeveloperDay wrote: > > > This is quite a mouthful before this lands do you want to consider > > > shortening it? > > > > > > `ShortNamespaceLength` ? > > > > > > I'm not sure non clang-formast developers will know what an UnwrappedLine > > > is? > > I agree that one needs to wrap its head around to digest this name. I'd > > vote for what @mydeveloperday proposed. > Although I already made some changes inside clang-format and single stepped > through some formations, I still can not explain what those UnwrappedLines > are. Just found a precedence for this: https://clang.llvm.org/extra/clang-tidy/checks/llvm-namespace-comment.html. This clang-tidy check uses `ShortNamespaceLines` for the very same thing so maybe we should match? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
