steveire added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:56 - hasEitherOperand(ignoringImpCasts( - anyOf(integerLiteral(equals(1)), - integerLiteral(equals(0)))))) ---------------- aaron.ballman wrote: > It looks like the changes drop the requirement that either operand is 0 or 1 > -- is that an oversight or can you explain why that's correct? Sorry, that was an old/intermediate version of the patch. ================ Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:101 - ignoringImpCasts(stringLiteral(hasSize(0))), - ignoringImpCasts(cxxBindTemporaryExpr(has(DefaultConstructor))), - ignoringImplicit(DefaultConstructor), ---------------- aaron.ballman wrote: > We seem to lose this case entirely? In `IgnoreUnlessSpelledInSource` mode, `ignoringImpCasts(cxxBindTemporaryExpr(has(DefaultConstructor)))` simplifies to `cxxConstructExpr(isDefaultConstruction())`, which is there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91303/new/ https://reviews.llvm.org/D91303 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
