tmsriram added inline comments.
================ Comment at: llvm/lib/Transforms/Utils/UniqueInternalLinkageNames.cpp:26-29 +static cl::opt<bool> UniqueDebugAndProfileNames( + "unqiue-debug-profile-names", cl::init(true), cl::Hidden, + cl::desc("Uniqueify debug and profile symbol Names")); + ---------------- hoy wrote: > dblaikie wrote: > > Do you have plans to use the flag in testing, etc? If not, I guess you > > might as well bake in the behavior you want if no one else is using > > this/there's no current use case for the flexibility? > I'm not quite sure if updating debug names are required in all use cases. > @tmsriram do you think we can just remove the flag? I vote for removing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits