hoy marked an inline comment as done. hoy added inline comments.
================ Comment at: llvm/test/Transforms/UniqueLinkageNames/unique-internal-linkage-names.ll:20 + +!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, enums: !2) +!1 = !DIFile(filename: "test.c", directory: "") ---------------- aeubanks wrote: > is the debug info necessary for the test? it passes without it. It's not needed. Will remove. ================ Comment at: llvm/test/Transforms/UniqueLinkageNames/unique-internal-linkage-names.ll:39 + +; O0: Running pass: VerifierPass +; O0: Running analysis: VerifierAnalysis ---------------- aeubanks wrote: > I don't think we need to check for Verifiers It shows up as the first pass of the O0 pipeline and I use it as a reference. Will remove. ================ Comment at: llvm/test/Transforms/UniqueLinkageNames/unique-internal-linkage-names.ll:44 + +; O2: Running pass: ForceFunctionAttrsPass +; O2: Running pass: UniqueInternalLinkageNamesPass ---------------- aeubanks wrote: > why check ForceFunctionAttrsPass? Like VerifierPass above, I was using it as a reference. ================ Comment at: llvm/test/Transforms/UniqueLinkageNames/unique-internal-linkage-names.ll:47 +; O2: Invalidating analysis: VerifierAnalysis +; O2: Running pass: SampleProfileProbePass + ---------------- aeubanks wrote: > should this be run for O0? There is no need for that as this point and running it under O0 is not tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits