fhahn added inline comments.
================
Comment at: clang/lib/Sema/SemaType.cpp:7855
+ return;
+ RowsExpr = Columns.get();
+ } else {
----------------
fhahn wrote:
> RKSimon wrote:
> > @fhahn Should this be ColsExpr?
> > ```
> > ColsExpr = Columns.get();
> > ```
> > Noticed when looking at
> > https://llvm.org/reports/scan-build/report-SemaType.cpp-BuildMatrixType-11-1.html#EndPath
> Thanks for pointing that out! Looks like a copy-paste error. I am just trying
> to come up with a test that actually exercises this code path (or remove it
> all together).
I put up D94092 to remove the code paths.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72281/new/
https://reviews.llvm.org/D72281
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
