george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land.
thanks for working on this! just one tiny nit and lgtm ================ Comment at: clang/lib/AST/ExprConstant.cpp:11408 // If we point to before the start of the object, there are no accessible // bytes. ---------------- nit: the new part of this condition makes this comment somewhat outdated. should it say something like "outside of" instead of "before"? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92892/new/ https://reviews.llvm.org/D92892 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits