sbenza accepted this revision.
================
Comment at: clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp:69
@@ +68,3 @@
+void UnconventionalAssignOperatorCheck::check(const MatchFinder::MatchResult
&Result) {
+ if (const auto *RetStmt = Result.Nodes.getNodeAs<ReturnStmt>("returnStmt")) {
+ diag(RetStmt->getLocStart(), "operator=() should always return '*this'");
----------------
baloghadamsoftware wrote:
> sbenza wrote:
> > couldn't this be folded into the Messages array below?
> There would be no benefit of it since we use the location of RetStmt in this
> message instead of Method.
Right. So it can't really be merged. That's fine.
http://reviews.llvm.org/D18265
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
