FreddyYe added inline comments.
================
Comment at: clang/lib/CodeGen/CGStmt.cpp:2488
+ if (Clobber == "eax") {
+ std::string::size_type position = Constraints.find("={eax}");
+ if (position != std::string::npos) {
----------------
pengfei wrote:
> `={eax}` is set in `X86_32TargetCodeGenInfo::addReturnRegisterOutputs`, which
> also handles `EAX:EDX` case by `=A`. I think it's better handle it in the
> function to cover the other case as well.
THX for review. Agree. I'll update.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94466/new/
https://reviews.llvm.org/D94466
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
