rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks this is a nice cleanup!
================
Comment at: include/clang/Sema/Sema.h:338-342
@@ +337,7 @@
+ PSK_Reset = 0x0, // #pragma ()
+ PSK_Set = 0x1, // #pragma ("name")
+ PSK_Push = 0x2, // #pragma (push[, id])
+ PSK_Pop = 0x4, // #pragma (pop[, id])
+ PSK_Push_Set = PSK_Push | PSK_Set, // #pragma (push[, id], "name")
+ PSK_Pop_Set = PSK_Pop | PSK_Set, // #pragma (pop[, id], "name")
+ };
----------------
These are now used for more than just section names. Can you replace `"name"`
with `value` in all the comments?
================
Comment at: include/clang/Sema/Sema.h:385-386
@@ +384,4 @@
+ : DefaultValue(Default), CurrentValue(Default) {}
+ explicit PragmaStack(const ValueType &Default, const ValueType &Value)
+ : DefaultValue(Default), CurrentValue(Value) {}
+
----------------
I don't see any users of this overload, where is it needed?
http://reviews.llvm.org/D19361
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
