jansvoboda11 added a comment. Thanks for taking a look! Committed with more detailed message.
================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1146 - Opts.SSPBufferSize = - getLastArgIntValue(Args, OPT_stack_protector_buffer_size, 8, Diags); - ---------------- dexonsmith wrote: > jansvoboda11 wrote: > > This piece of code should've been removed in D84669 which added marshalling > > info to `stack_protector_buffer_size`. > In that case please commit this separately. Since I presume it's NFC and > pretty straightforward, likely you don't need a separate review, but please > make sure the commit message is good / refers to what made it NFC / etc.. Makes sense, committed in https://reviews.llvm.org/rG3bccd87a588b3c320b669686c8f006b92ff72182. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94488/new/ https://reviews.llvm.org/D94488 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
