curdeius accepted this revision.
curdeius added a comment.
One last nit, otherwise LGTM.
================
Comment at: clang/unittests/Format/FormatTest.cpp:8891
+TEST_F(FormatTest, FormatsAccessModifiers) {
+ verifyFormat("struct foo {\n"
+ "private:\n"
----------------
For the ease of understanding that you test `LogicalBlock` in this first part,
I'd add:
```
FormatStyle Style = getLLVMStyle();
EXPECT_EQ(Style.EmptyLineBeforeAccessModifier,
FormatStyle::ELBAMS_LogicalBlock);
```
and use this `Style` in `verifyFormat`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93846/new/
https://reviews.llvm.org/D93846
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
