akhuang added inline comments.
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052
+ // Don't include a linkage name in line tables only.
+ if (CGM.getCodeGenOpts().hasReducedDebugInfo())
+ Identifier = getTypeIdentifier(Ty, CGM, TheCU);
----------------
rnk wrote:
> I see Amy included the linkage name step as part of this patch, so disregard
> that comment.
oops, didn't realize that I included it here. Anyway, I can commit this
separately.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:370-373
+ // MSVC, if not using line tables only.
+ StringRef DisplayName = SP->getName();
+ if (SP->getUnit()->getEmissionKind() != DICompileUnit::LineTablesOnly)
+ DisplayName = SP->getName().split('<').first;
----------------
rnk wrote:
> Do we still need the LLVM part of this? We needed it before because we were
> operating on strings like `foo::<unnamed-tag>::operator()`. Can we leave it
> as is for now, or handle it as a separate patch?
Oh, right. I don't think we need this anymore..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94639/new/
https://reviews.llvm.org/D94639
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
