wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land.
LGTM. Thanks. ================ Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:363 const FunctionSamples *CalleeSamples; uint64_t CallsiteCount; + // Call site distribution factor to prorate the profile samples for a ---------------- hoy wrote: > wmi wrote: > > CallsiteCount will be the count before being prorated or after if > > CallsiteDistribution is not 1.0? > It is the count after prorated. The prorated count will be used to guide > inlining. For example, if a callsite is duplicated in LTO prelink, then in > LTO postlink the two copies will get their own distribution factors and their > prorated counts are used to decide if they should be inlined independently. Ok, better comment it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93264/new/ https://reviews.llvm.org/D93264 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
