JonChesterfield added a comment.

I don't think introducing everything from the cuda namespace into openmp nvptx 
offloading is a feature. Inevitably people will call threadIdx.x instead of the 
openmp or clang equivalent, and this will mask missing functionality in openmp.

I won't object too strongly, as ultimately I don't care about cuda, but I view 
intertwining the two implementations as technical debt.

Note that a cuda-free openmp devicertl compilation doesn't require this patch, 
or any other pieces of cuda headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94884/new/

https://reviews.llvm.org/D94884

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to