akhuang added inline comments.
================ Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052 + // Don't include a linkage name in line tables only, except to differentiate + // between lambdas. + if (CGM.getCodeGenOpts().hasReducedDebugInfo() || RD->isLambda()) ---------------- dblaikie wrote: > rnk wrote: > > We discussed giving lambdas display names as an alternative to doing this. > Should this be only for CodeView (due to CV's need for functions to be > distinct in some way)? Adding the linkage name could increase debug info size > for DWARF consumers unnecessarily I think the CodeView change is elsewhere - here it just makes sure we only emit linkage names if it's not line tables only. (Now I'm remembering me creating the `hasReducedDebugInfo` function and the naming is pretty confusing...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95001/new/ https://reviews.llvm.org/D95001 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
