tstellar added inline comments.
================ Comment at: clang/tools/clang-shlib/CMakeLists.txt:54 + PROPERTIES + SOVERSION ${LIBCLANG_LIBRARY_VERSION}) ---------------- cuviper wrote: > tstellar wrote: > > cuviper wrote: > > > I think you also need `VERSION` here, or else it symlinks back to > > > `.so.11`. > > I think add_clang_library is setting VERSION. This is what I get when I > > build: > > > > lib/libclang-cpp.so -> libclang-cpp.so.11.1 > > lib/libclang.so -> libclang.so.11.1 > > > I see those links, but also `lib/libclang-cpp.so.11.1 -> libclang-cpp.so.11`, > with the latter being the real file. If I add `VERSION` explicitly, that goes > away. > (I had to delete `lib/libclang*.so*` before rebuilding too.) OK, I see it now. I can fix that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits