Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land.
LGTM, great! Thanks! Perhaps the test can be simplified before committing... ================ Comment at: clang/test/CodeGenOpenCL/vector_literals.cl:71 + // CHECK: extractelement <2 x i32> %{{[0-9]+}}, i64 0 + unsigned int withCast = ((int2)((int2)(12, 34))).s0; +} ---------------- I wonder if both `(int2)` are needed i.e. the cast one could be ommitted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95135/new/ https://reviews.llvm.org/D95135 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits