sammccall added a comment. In D95270#2519052 <https://reviews.llvm.org/D95270#2519052>, @sammccall wrote:
> I'm not convinced this is clearer - these methods do in fact return `null`. > And it adds more duplicative code. Is it necessary? Doh, of course I misread - inputs rather than outputs. Yes, this seems OK if we drop the NoParams variants. (Though I'm still not sure it's worth the special case...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95270/new/ https://reviews.llvm.org/D95270 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits