dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM.

> This somewhat weakens the guarantees that we're referring to an existing 
> (option) record, but we can still use the option.KeyPath syntax to simulate 
> this.

I agree that using `<option>.KeyPath` is sufficient to enforce ordering.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95344/new/

https://reviews.llvm.org/D95344

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D95344: [c... Jan Svoboda via Phabricator via cfe-commits
    • [PATCH] D9534... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D9534... Jan Svoboda via Phabricator via cfe-commits

Reply via email to