rjmccall added inline comments.
================ Comment at: clang/lib/AST/ItaniumMangle.cpp:3912 + IsPrimaryExpr = false; + }; + ---------------- I think it might be more reasonable to just check for the relatively small number of primary-expression cases in `mangleTemplateArgExpr` and skip the `X...E` there rather than pushing it down into this function. ================ Comment at: clang/lib/AST/ItaniumMangle.cpp:5159 + // (subtype of VarDecl) _incorrectly_, and emitted 'L_Z .. E' instead of + // the proper 'Xfp_E'. E = E->IgnoreParenImpCasts(); ---------------- Oops. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95487/new/ https://reviews.llvm.org/D95487 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
