kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks, lgtm! ================ Comment at: clang-tools-extra/clangd/support/Function.h:54 if (Parent) { - std::lock_guard<std::recursive_mutex>(Parent->ListenersMu); + std::lock_guard<std::recursive_mutex> Guard(Parent->ListenersMu); llvm::erase_if(Parent->Listeners, ---------------- nit: we prefer `Lock` rather than `Guard` in other places. so `s/Guard/Lock/` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95725/new/ https://reviews.llvm.org/D95725 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits