jyknight added a comment.

My concern is that this is treating a backend _bug_ as if it were just an 
optional feature. But it's not the case that it might be reasonable to either 
implement or not implement this in a backend -- it should be implemented, and 
those that don't are buggy.

I'd be happier with just having an ISEL failure when you try to use fp atomics 
on broken targets, rather than adding all this code and configuration to Clang 
in order to avoid that. (And, of course, the target maintainers should also fix 
them)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71726/new/

https://reviews.llvm.org/D71726

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to