njames93 added inline comments.
================
Comment at: clang/unittests/Format/FormatTest.cpp:17996
+ format(ForSourceLong, Style));
+}
+
----------------
MyDeveloperDay wrote:
> MyDeveloperDay wrote:
> > MyDeveloperDay wrote:
> > > are you testing do/while?
> > whilst people discuss the ethics of modifying the code ;-)
> >
> > Can you add some comment based examples
> >
> > ```
> > if (condition) // my test
> > you_do_you();
> >
> > if (condition)
> > you_do_you(); // my test
> > ```
> bonus points..
>
> ```
> if /*condition*/ (condition) /*condition*/
> /*condition*/ you_do_you(); /*condition*/
> ```
Should also add test for chained conditionals just to make sure the semantics
of the code doesn't change.
```lang=c
if (A)
if (B)
callAB();
else
callA();
else if (B)
callB();
else
call();```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95168/new/
https://reviews.llvm.org/D95168
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
