rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
Looks good with one suggestion. ================ Comment at: clang/include/clang/AST/ASTContext.h:540 llvm::MapVector<const NamedDecl *, unsigned> MangleNumbers; llvm::MapVector<const VarDecl *, unsigned> StaticLocalNumbers; ---------------- This is a nit, but I'd group the device mangling number map here with the other mangling number side tables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
