jrtc27 added inline comments.
================ Comment at: clang/include/clang/Basic/Attr.td:1541 + // NOTE: If you add any additional spellings, ARMInterrupt's, MipsInterrupt's + // and AnyX86Interrupt's spellings must match. + let Spellings = [GNU<"interrupt">]; ---------------- Do you need to add M68kInterrupt to this list, including for all the other copies of it? ================ Comment at: clang/lib/Basic/Targets/M68k.cpp:142 + const char *&Name, TargetInfo::ConstraintInfo &info) const { + // FIXME: implement + switch (*Name) { ---------------- This is implemented? ================ Comment at: clang/lib/Basic/Targets/M68k.cpp:164 +M68kTargetInfo::BuiltinVaListKind M68kTargetInfo::getBuiltinVaListKind() const { + // FIXME: implement + return TargetInfo::CharPtrBuiltinVaList; ---------------- Use assert/llvm_unreachable if this is wrong ================ Comment at: clang/lib/Basic/Targets/M68k.h:57 + +#endif /* end of include guard: M680X0_H_LTNCIPAD */ ---------------- (not even the right guard name) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits