stefanp accepted this revision as: stefanp. stefanp added a comment. This revision is now accepted and ready to land.
I just have one final nit otherwise LGTM. Feel free to fix that on commit. Please wait a couple of days and see if @MaskRay has any further comments. ================ Comment at: lld/test/ELF/ppc64-pcrel-call-to-extern.s:135 + +## .plt[3] - 0x10020010 = 0x10030160 - 0x10020010 = 0x10150 = 65888 # CHECK-LABEL: <__plt_pcrel_callee_global_stother1>: ---------------- stefanp wrote: > nit: > Please fix these comments. > `0x10150` does not equal `65888`. nit: I think these numbers are still wrong. ``` 0x10030160 - 0x10020010 = 0x10150 not 0x10160 ``` I think it should be: `0x10030170` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94627/new/ https://reviews.llvm.org/D94627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits