aaron.ballman added a comment.

Thank you for working on this! In general, I like the change.



================
Comment at: clang/lib/AST/TypePrinter.cpp:1308
+    } else if ((isa<RecordDecl>(D) && 
cast<RecordDecl>(D)->isAnonymousStructOrUnion()) ||
+        isa<EnumDecl>(D)) {
       OS << "anonymous";
----------------
I think `EnumDecl` should probably be `unnamed` rather than `anonymous` because 
there's no term of art for an anonymous enumeration (there's only anonymous 
structures and anonymous unions). WDYT?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96807/new/

https://reviews.llvm.org/D96807

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to