jansvoboda11 added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4267
 
+  if (Triple.isSPIR())
+    CmdArgs.push_back("-Wspir-compat");
----------------
Anastasia wrote:
> It seems like this should have been in `addClangWarningOptions` but there is 
> no toolchain for SPIR?
> 
> Could we add a FIXME at least saying that this deviates from the default flow 
> right now?
That's right. I added the FIXME.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97041/new/

https://reviews.llvm.org/D97041

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to