aaron.ballman added a comment. In D89065#2320031 <https://reviews.llvm.org/D89065#2320031>, @njames93 wrote:
> I don't see any support for verifying fix-its in the test cases so unsure how > i could go about testing this change. We usually test fix-its with `-fdiagnostics-parseable-fixits` as in the tests here: https://github.com/llvm/llvm-project/tree/main/clang/test/FixIt (not saying the test has to go into the `FixIt` directory, it should probably live in `test/Parser` given the changes.) Btw, this is going to cause merge conflicts with https://reviews.llvm.org/D95396 and I sort of wonder if we should combine the two patches into one given that they're fixing the same code in different ways. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits