pengfei added inline comments.
================
Comment at: clang/lib/Headers/amxintrin.h:283
+typedef struct __tile1024bf16_str {
+ const unsigned short row;
----------------
LiuChen3 wrote:
> LuoYuanke wrote:
> > pengfei wrote:
> > > Is there much value to differentiate the type? We are using the same AMX
> > > type in the builtins. What do you think? @LuoYuanke
> > My first though is that we can reuse __tile1024i for bf16 tile for 2
> > reasons.
> > 1. We don't access the element of the tile.
> > 2. The destination element of amx-int8 is int32 and the destination element
> > of amx-bf16 is float32, the element size is the same.
> Does this means that user need to do explicitly type conversion?
We don't allow user to use the tile in the structure. User should always use
load/store intrinsic to pass there own data.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97358/new/
https://reviews.llvm.org/D97358
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
