craig.topper added inline comments.
================ Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:567 + // Compute type transformers + for (char I : Transformer.take_front(Transformer.size() - 1)) { + switch (I) { ---------------- jrtc27 wrote: > craig.topper wrote: > > Can we do Transformer = Transformer.drop_back() right before this loop. > > That take_front code is harder to think about. > Or would it be better as a pop_back in the switch above? I don't think StringRef has a pop_back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits