aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D97491#2589098 <https://reviews.llvm.org/D97491#2589098>, @Eugene.Zelenko wrote: > In D97491#2589097 <https://reviews.llvm.org/D97491#2589097>, @njames93 wrote: > >> In D97491#2588835 <https://reviews.llvm.org/D97491#2588835>, @Eugene.Zelenko >> wrote: >> >>> If `Wdefaulted-function-deleted` was introduced in 12.0, I think it's safe >>> just to remove `readability-deleted-default`. >> >> Wdefaulted-function-deleted was introduced in 8.0 and I think it was enabled >> by default even then. I'm thinking we may be able to squeeze this notice >> into the 12 branch and then it will be gone by 13 > > Frankly, I don't remember any deprecated check in past. Obsolete checks were > just removed and this change was reflected in Release Notes. With checks that have been released to the public, I think it's good to have a notice that the check was deprecated before we remove it. LGTM! If we want to squeeze the notice into 12, I think that's also reasonable, but given that this has been around for a while, I'm also fine with a slightly longer deprecation period. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97491/new/ https://reviews.llvm.org/D97491 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
