ychen added inline comments.
================
Comment at: llvm/lib/MC/MCContext.cpp:870
+ std::function<void(SMDiagnostic &, const SourceMgr *)> GetMessage) {
+ SourceMgr SM;
+ const SourceMgr *SMP = &SM;
----------------
MaskRay wrote:
> This looks a bit strange: we need to construct a fresh SourceMgr to print a
> diagnostic.
I've included comments to explain that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97449/new/
https://reviews.llvm.org/D97449
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
